[tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-------------------------------------------------+-------------------------
 Reporter:  sjmurdoch                            |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.2.32
 Severity:  Normal                               |     Resolution:
 Keywords:  regression tor-client 032-backport   |  Actual Points:
  031-backport 029-backport 033-must review-     |
  group-33                                       |
Parent ID:                                       |         Points:
 Reviewer:  nickm, isis                          |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by isis):

 * reviewer:  nickm => nickm, isis


Comment:

 I tested this on a tor-0.3.1.4-alpha (the version just after when
 `AllowDotExit` was removed). I'm not able to reproduce the issue? It could
 very well be that I've not taken the right steps, since it's been so long
 since I've tried to manually use .exit notation. In the arm control panel,
 I did:

 {{{
 >>> MAPADDRESS
 google.com=google.com.9D6AE1BD4FDF39721CE908966E79E16F9BFCCF2F.exit
 google.com=google.com.9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f.exit
 >>> GETINFO address-mappings/all
 google.com.9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f.exit
 172.217.22.142.9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f.exit "2018-03-01
 01:57:29"
 }}}

 I then went to google.com, and my tor seems to have built a four-hop
 circuit, with `9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f` as the exit node
 to google.com.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3940#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online