[tor-bugs] #26576 [Applications/Tor Browser]: Don't find absolute path from /proc/self/exe

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jun 29 21:36:35 UTC 2018


#26576: Don't find absolute path from /proc/self/exe
------------------------------------------+----------------------
     Reporter:  sysrqb                    |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 Similar to #20283, Mozilla cleaned up their 13+ year old code for finding
 the install directory path in
 [[https://bugzilla.mozilla.org/show_bug.cgi?id=1403366|Bug 1403366]].
 Instead of relying on argv[0], they now follow `/proc/self/exe` on Linux
 systems (they changed how they handle this on other platforms, too).

 I'm not sure if we should revert part of the patch.

 {{{
 commit 4fe745918004db0e36e737f945901650be10c1de
 Author: Mike Hommey <mh+mozilla at glandium.org>
 Date:   Thu Sep 28 10:37:27 2017 +0900

     Bug 1403366 - Stop requiring argv[0] for XRE_GetBinaryPath and the
 underlying BinaryPath::Get. r=froydnj

     --HG--
     extra : rebase_source : ac7bb0d7766fce5b6325c34c2868b26eec594e18
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26576>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list