[tor-bugs] #26497 [Core Tor/Tor]: set CARGO_HOME correctly or stop using it

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jun 25 17:00:58 UTC 2018


#26497: set CARGO_HOME correctly or stop using it
------------------------------+--------------------------------
     Reporter:  catalyst      |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  rust, tor-ci
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 It looks like we set `CARGO_HOME` incorrectly for invocations of both
 `cargo build` and `cargo test`.  The `cargo build` invocations work
 because we first `cd` to the directory containing the `.cargo` directory.
 The `cargo test` invocations don't work for out-of-source-tree builds.
 #26455 contains a more minimal fix.

 The setting of `CARGO_HOME` is redundant if we `cd` to the correct
 directory first.  Or we could stop changing directories and instead set
 `CARGO_HOME` correctly.  We probably shouldn't do both because it's
 confusing and possibly inconsistent.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26497>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list