[tor-bugs] #24658 [Core Tor/Tor]: Split/refactor crypto.h into smaller separate modules

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jun 21 21:20:56 UTC 2018


#24658: Split/refactor crypto.h into smaller separate modules
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-crypto, refactor, review-        |  Actual Points:
  group-32, review-group-34,                     |
  033-triage-20180320, 033-included-20180320     |
Parent ID:                                       |         Points:
 Reviewer:  nickm, isis                          |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by bc348):

 Replying to [comment:56 nickm]:
 > Does 599b53f0469e47 solve that for you?

 Yes. compiles ok, but after today's bunch of commits some tests do not
 pass


 {{{
 geoip/load_file: [forking]
   FAIL src/test/test_geoip.c:445: assert(dhex OP_EQ
 geoip_db_digest(AF_INET)): <9350CC266D3467466AB28C354DFAD7FB7706A5D7> vs
 <B4682B8832074D2F8386675A47040243775D588E>
   [load_file FAILED]
 geoip/load_file6: [forking]
   FAIL src/test/test_geoip.c:520: assert(dhex OP_EQ
 geoip_db_digest(AF_INET6)): <FAD0815096C1EF4A36491782F7E100BE781DD235> vs
 <9181B66BD1932D195B50713C6EA4762AF0498BCB>
   [load_file6 FAILED]
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24658#comment:57>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list