[tor-bugs] #24658 [Core Tor/Tor]: Split/refactor crypto.h into smaller separate modules

[Tor Bug Tracker & Wiki]

#24658: Split/refactor crypto.h into smaller separate modules
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:  nickm
     Type:  enhancement                          |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-crypto, refactor, review-        |  Actual Points:
  group-32, review-group-34,                     |
  033-triage-20180320, 033-included-20180320     |
Parent ID:                                       |         Points:
 Reviewer:  nickm, isis                          |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by bc348):

 compile error with mingw after commit 3640c63

 {{{
 src/common/crypto_dh.c:90:5: error: unknown type name 'BN_ULONG'; did you
 mean 'PULONG'?
      BN_ULONG residue = BN_mod_word(p, 24);
      ^~~~~~~~
      PULONG
 }}}

 After adding  `#include <openssl/bn.h>`
 to `crypto-dh.c`  compiles ok

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24658#comment:54>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online