[tor-bugs] #26383 [Core Tor/Tor]: Move structures out of or.h

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jun 15 19:51:06 UTC 2018


#26383: Move structures out of or.h
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  Sponsor8-can
--------------------------+------------------------------------
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 The branch is "split_or_h", and there's a pull request here:
 https://github.com/torproject/tor/pull/151

 This branch does not move all the structures yet, but I'd like to do this
 batch first, and then take care of the remainder.

 If possible, I'd like to take this right away in 0.3.5.

 Notes for the reviewer:
   * If possible, please separate stuff that I must fix before merging from
 stuff that would be ok to fix afterwards: if this branch sits unmerged for
 a long time, it will rot badly.
   * You might find the --color-moved option in the latest versions of git
 to be useful in verifying that certain commits are pure code movement.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26383#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list