[tor-bugs] #26283 [Core Tor/Tor]: smartlist_len cast to double

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jun 12 10:03:18 UTC 2018


#26283: smartlist_len cast to double
--------------------------+------------------------------------
 Reporter:  rl1987        |          Owner:  (none)
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:  fast-fix      |  Actual Points:
Parent ID:  #26196        |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 I can verify that the patch resolves the warning when DEBUG_SMARTLIST is
 enabled.

 The return value of the division should remain the same (a double), since
 the numerator of the division is a double.

 LGTM.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26283#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list