[tor-bugs] #26259 [Core Tor/Tor]: Don't count 0-length RELAY_DATA cell as valid

[Tor Bug Tracker & Wiki]

#26259: Don't count 0-length RELAY_DATA cell as valid
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay-layer, tor-metrics, tor-   |  Actual Points:
  circuit                                        |
Parent ID:                                       |         Points:  1
 Reviewer:  isis                                 |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 Replying to [comment:5 isis]:
 > Replying to [comment:3 mikeperry]:
 > > Possibly. Do we feel comfortable forbidding these cells completely in
 0.3.4.x? I would prefer to have this branch merged into 0.3.4, since it is
 just a control port field accounting fix.
 > >
 > > If we're nervous about actually closing the circuit right away in
 these instances, then we should make a different ticket + different patch
 for that change.
 >
 > Different ticket and patch please! This one is clearly a bug;
 disallowing 0-length data cells entirely seems more contentious, possible
 requires a spec change, and has a higher possibility of breaking things.

 +1 on a different ticket and patch; and if we do it, we need to figure out
 how we're handling the fingerprinting issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26259#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online