[tor-bugs] #26320 [Applications/Tor Browser]: Orfox 52.8.0esr-7.5-1 Crash

[Tor Bug Tracker & Wiki]

#26320: Orfox 52.8.0esr-7.5-1 Crash
--------------------------------------+-----------------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  Immediate                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------

Comment (by sysrqb):

 I think we'll need to use the non-optimized build. The short explanation
 is fennec still crashes using -O1 (different from the default optimization
 -Os).

 The slightly longer answer is I tried compiling with the -O1 optimization
 flag, but I experienced a compile-time errors, so one (or more) of the
 optimizations enabled by `-Os` enforces the inlining requirement:

 {{{
  4:34.47 In file included from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/dist/system_wrappers/string:3:0,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/dist/stl_wrappers/string:44,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-
 browser/ipc/chromium/src/base/platform_file.h:15,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-
 browser/ipc/chromium/src/base/platform_file_posix.cc:7,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/ipc/chromium/Unified_cpp_ipc_chromium1.cpp:2:
  4:34.47 /home/sysrqb/.mozbuild/android-ndk-r11b//sources/cxx-stl/llvm-
 libc++/libcxx/include/string: In member function 'bool
 base::SharedMemory::FilenameForMemoryName(const wstring&,
 std::__ndk1::wstring*)':
  4:34.47 /home/sysrqb/.mozbuild/android-ndk-r11b//sources/cxx-stl/llvm-
 libc++/libcxx/include/string:700:35: error: inlining failed in call to
 always_inline 'static constexpr bool std::__ndk1::char_traits<wchar_t
 >::eq(std::__ndk1::char_traits<wchar_t>::char_type,
 std::__ndk1::char_traits<wchar_t>::char_type) throw ()': indirect function
 call with a yet undetermined callee
  4:34.47      static _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type
 __c2) _NOEXCEPT
  4:34.47
 [...]
  4:34.47 In file included from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/dist/system_wrappers/algorithm:3:0,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/dist/stl_wrappers/algorithm:44,
  4:34.47                  from /home/sysrqb/.mozbuild/android-ndk-
 r11b//sources/cxx-stl/llvm-libc++/libcxx/include/string:439,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/dist/system_wrappers/string:3,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/dist/stl_wrappers/string:44,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-
 browser/ipc/chromium/src/base/platform_file.h:15,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-
 browser/ipc/chromium/src/base/platform_file_posix.cc:7,
  4:34.47                  from /home/sysrqb/Orfox/external/tor-browser
 /obj-arm-linux-androideabi/ipc/chromium/Unified_cpp_ipc_chromium1.cpp:2:
  4:34.47 /home/sysrqb/.mozbuild/android-ndk-r11b//sources/cxx-stl/llvm-
 libc++/libcxx/include/algorithm:1050:13: error: called from here
  4:34.47              if (__pred(*__first1, *__j))
 }}}

 I added `-findirect-inlining` (the name was a good hint), and that solved
 the compile-time error - so it seems like Android NDK 11b requires this,
 at least. Unfortunately, the app still crashes on the test webpage.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26320#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online