[tor-bugs] #26284 [Core Tor/Tor]: Out-of-bounds smartlist access in protover_compute_vote()

[Tor Bug Tracker & Wiki]

#26284: Out-of-bounds smartlist access in protover_compute_vote()
--------------------------+------------------------------------
 Reporter:  rl1987        |          Owner:  rl1987
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:  fast-fix      |  Actual Points:
Parent ID:  #26196        |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Cool find rl1987! How did you repro this?

 Do you think this needs to be backported? The way I understand it this can
 only trigger if all authorities don't participate in the protover
 protocol, which seems pretty unlikely.

 Also I made some notes in the PR! Let me know how you like them!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26284#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online