[tor-bugs] #17417 [Core Tor/Tor]: fail self-test for cert_new in v0.2.8.0-alpha-dev NetBSD 6_Stable

[Tor Bug Tracker & Wiki]

#17417: fail self-test for cert_new in v0.2.8.0-alpha-dev NetBSD 6_Stable
--------------------------+------------------------------------
 Reporter:  yancm         |          Owner:  (none)
     Type:  defect        |         Status:  closed
 Priority:  Medium        |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:  fixed
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by rl1987):

 Replying to [comment:8 yancm]:
 > Ah, ok... If I understand the short of it; with bleeding edge OpenSSL,
 ret is passed by value to tor_x509_cert_free() so ret cannot be set to
 NULL there? And later in the test subroutine, we free ret again?
 >

 Yes.

 > It seems odd to me to call a "free" anything (memory/records/etc)
 without returning a success or fail code, or some other status that can be
 reacted to...then you know when you NULL ret it has indeed been
 successfully free'd first... maybe we do not care if we NULL ret even if
 it was not successfully free'd?

 Well, we're done with this instance of the object and we're not going to
 need it so we're freeing it. The lifecycle is over. We shouldn't worry
 about `free()` failing as it shouldn't happen.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17417#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online