[tor-bugs] #26994 [Core Tor/Tor]: test_bwmgt.c compile error with tor-0.3.4.5-rc

[Tor Bug Tracker & Wiki]

#26994: test_bwmgt.c compile error with tor-0.3.4.5-rc
-------------------------------------------------+-------------------------
 Reporter:  Knut                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.4.5-rc
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-test, solaris, regression,       |  Actual Points:
  035-must                                       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  test_bwmgt.c => tor-test, solaris, regression, 035-must
 * status:  new => needs_information
 * component:  Core Tor => Core Tor/Tor
 * milestone:   => Tor: 0.3.5.x-final


Old description:

> I'm running in the same compile error on all tor-0.3.4.* versions
> when trying to build tor on Solaris 10
> tor-0.3.3.9 builds and works without any issue.
>
> The error looks like:
>
> In file included from /usr/include/sys/select.h:23:0,
>                  from /usr/include/sys/types.h:616,
>                  from /usr/include/unistd.h:20,
>                  from ./src/or/or.h:18,
>                  from src/test/test_bwmgt.c:11:
> src/test/test_bwmgt.c: In function ‘test_bwmgt_token_buf_refill’:
> src/test/test_bwmgt.c:127:18: error: expected identifier or ‘(’ before
> numeric constant
>    const uint32_t SEC =
>                   ^
> gmake[1]: *** [src/test/src_test_test-test_bwmgt.o] Error 1
> gmake[1]: Leaving directory `/usr/local/lib/tor-0.3.4.5-rc'
> gmake: *** [all] Error 2
>
> Any help is appreciated.
>
> Thanks.
>
> Knut

New description:

 I'm running in the same compile error on all tor-0.3.4.* versions
 when trying to build tor on Solaris 10
 tor-0.3.3.9 builds and works without any issue.

 The error looks like:

 {{{
 In file included from /usr/include/sys/select.h:23:0,
                  from /usr/include/sys/types.h:616,
                  from /usr/include/unistd.h:20,
                  from ./src/or/or.h:18,
                  from src/test/test_bwmgt.c:11:
 src/test/test_bwmgt.c: In function ‘test_bwmgt_token_buf_refill’:
 src/test/test_bwmgt.c:127:18: error: expected identifier or ‘(’ before
 numeric constant
    const uint32_t SEC =
                   ^
 gmake[1]: *** [src/test/src_test_test-test_bwmgt.o] Error 1
 gmake[1]: Leaving directory `/usr/local/lib/tor-0.3.4.5-rc'
 gmake: *** [all] Error 2
 }}}

 Any help is appreciated.

 Thanks.

 Knut

--

Comment:

 Hi, thanks for this bug report.

 Do any standard Solaris headers define a macro "SEC"?

 What happens if you search and replace "SEC" with "BW_SEC" in
 test_bwmgt.c?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26994#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online