[tor-bugs] #23759 [Core Tor/Tor]: Refactor common code out of setup_introduce1_data and intro point functions

[Tor Bug Tracker & Wiki]

#23759: Refactor common code out of setup_introduce1_data and intro point functions
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, refactor, 034-triage-20180328,           |
  034-removed-20180328                           |
Parent ID:  #22781                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * parent:  #23576 => #22781


Old description:

> During #23577, we discovered that there's a lot of code in
> setup_introduce1_data() that's duplicated in service_intro_point_new()
> and hs_desc_lspec_to_trunnel().
>
> And in #23577, we want to copy more of it.
>
> So we should clean that up at some point, but it's complicated, because
> the intro point functions use hs_desc_link_specifier_t.
>
> Or we could add comments in the duplicate code to tell us to check the
> other functions when any one of them changes.

New description:

 During #23577, we discovered that there's a lot of code in
 setup_introduce1_data() that's duplicated in service_intro_point_new() and
 hs_desc_lspec_to_trunnel().

 In #23576, we removed the duplication across setup_introduce1_data() and
 service_intro_point_new(), creating node_get_link_specifier_smartlist().

 So we should clean that up at some point, but it's complicated, because
 the intro point functions use hs_desc_link_specifier_t. (See #22781)

 Edit: update after #23576.

--

Comment:

 Oops, no we don't.

 Fixing #23576 removes the duplication across setup_introduce1_data() and
 service_intro_point_new().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23759#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online