[tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

[Tor Bug Tracker & Wiki]

#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328                           |
Parent ID:  #23493                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


Comment:

 Replying to [comment:10 neel]:
 > My PR is here: https://github.com/torproject/tor/pull/252

 Thanks for this patch!

 The unit tests fail in the new function:
 https://travis-ci.org/torproject/tor/jobs/409667005#L3572

 Please add new commits to the branch to make them pass.

 You can run the unit tests before you push your branch using:
 {{{
 make check
 }}}

 You might be able to see the CI status on:
 https://github.com/torproject/tor/pull/252
 https://travis-ci.org/torproject/tor
 https://ci.appveyor.com/project/torproject/tor

 If you can't, let us know, and we'll work out how to get you access.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online