[tor-bugs] #26955 [Core Tor/Tor]: Privcount blinding and encryption: rustfmt

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jul 30 03:48:21 UTC 2018


#26955: Privcount blinding and encryption: rustfmt
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust                     |
Parent ID:  #25669                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:3 chelseakomlo]:
 > There are a lot of changes in this PR so I didn't look at each one
 closely, but (from what I saw) if these changes are all automatic changes
 from running rustfmt on each file, then this looks good to merge to me.

 Thanks!

 > Btw, I set up my .vimrc to run rustfmt each time I save on the file that
 I'm working on, it might be helpful to do this for future work. This is
 what I used but I'm sure there are other options https://github.com/rust-
 lang/rust.vim#formatting-with-rustfmt

 I have done the same with emacs:
 https://github.com/rust-lang/rust-mode

 > As a note to the future, we should probably set up a CI task for core
 tor to check if Rust files haven't been formatted with rustfmt (I don't
 think we do this currently after looking at the build). I can open a
 ticket to track this.

 Thanks! Please post the ticket number here.

 I opened #26973 for the same change to the privcount_shamir CI.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26955#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list