[tor-bugs] #26574 [Applications/Tor Browser]: Save TBA updates in the internal android storage

[Tor Bug Tracker & Wiki]

#26574: Save TBA updates in the internal android storage
-----------------------------------------------+---------------------------
 Reporter:  igt0                               |          Owner:  tbb-team
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26242                             |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by igt0):

 Replying to [comment:9 sysrqb]:
 > Replying to [comment:3 igt0]:
 > > I found a workaround that allows the PackageInstaller to access and
 read the file [File.setReadable(true, false)] [0].
 > >
 > > However, when the APK is being installed, Fennec throws a strict
 policy violation exception:
 >
 > The patch looks good (but I didn't test it). Do you know or remember
 when this strict policy violation exception was thrown? Was it after the
 download was completed? Also, can you describe how you tested this?

 Strict policy violation: it was an issue in my side. I was pointing for an
 APK with different ID, thus the updater was not allowing an app A update
 an app B (that is good!).

 Was it after the download was completed: No, when the download is
 completed, an android notification is sent and the user must click on it
 to start the update process.

 How to test: There are two preferences you need to change
 app.update.autodownload and app.update.url.android.

 The app.update.autodownload you can change to 2(it means enabled).

 The app.update.url.android is the hard part:

 1. Create an update server (https://developer.mozilla.org/en-
 US/docs/Mozilla/Setting_up_an_update_server)
 2. Point the app.update.url.android to the update server:

 <MY_ONION_DOMAIN>/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/%MOZ_VERSION%/update.xml

 3. go to: Settings -> The Tor Project Tor Browser(last option) -> About
 Tor Browser

 And click in the check for updates, if everything is in place it will
 start to download the apk and in the end you will see a notification about
 updating TBA.

 So things that we need to do before merging the patch, we need to decide
 if the URL makes sense for us or if we can make it shorter. And update the
 prefs file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26574#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online