[tor-bugs] #26932 [Core Tor/Tor]: Soft assert in HS3 with vanguards ([warn] Invalid signature for service descriptor signing key: expired)

[Tor Bug Tracker & Wiki]

#26932: Soft assert in HS3 with vanguards ([warn] Invalid signature for service
descriptor signing key: expired)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs possible-regression bug easy  |  Actual Points:
  034-backport 033-backport-maybe 032-backport-  |
  maybe                                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Yep, it's a simple patch.

 I've been considering whether it's possible changing the logic of
 `move_hs_state()` so that instead of doing the shallow copy by naively
 copying elements around, we just do a `memcpy()` between the two structs.
 Might be more future-proof to avoid similar bugs in the future.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26932#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online