[tor-bugs] #26958 [Core Tor/Tor]: Privcount blinding and encryption: run clippy on travis rust nightly

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jul 27 10:32:33 UTC 2018


#26958: Privcount blinding and encryption: run clippy on travis rust nightly
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust                     |
Parent ID:  #25669                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by chelseakomlo):

 Hey! Yes I don't think passing all clippy warnings should be mandatory. It
 is useful to run clippy locally, and overall we should in the future come
 up with a set of clippy warnings that we want to pass by default, but for
 the short term it probably? shouldn't be part of the CI build. See
 https://trac.torproject.org/projects/tor/ticket/22156 for more context.

 With that said, looking over these warnings locally and fixing up those
 which could result in actual bugs seems like a good idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26958#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list