[tor-bugs] #26447 [Core Tor/Tor]: Add check-includes to check-local?

[Tor Bug Tracker & Wiki]

#26447: Add check-includes to check-local?
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, ci, modularity, fast-fix, 035  |  Actual Points:
  -triaged-in-20180711                           |
Parent ID:                                       |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Oops, sorry, I didn't see this ticket last week.

 When building out of tree, I see:
 {{{
 perl ../scripts/maint/checkSpace.pl -C \
                 ../src/lib/*/*.[ch] \
                 ../src/core/*/*.[ch] \
                 ../src/feature/*/*.[ch] \
                 ../src/app/*/*.[ch] \
                 ../src/test/*.[ch] \
                 ../src/test/*/*.[ch] \
                 ../src/tools/*.[ch]
 ../scripts/maint/checkIncludes.py
 make[1]: ../scripts/maint/checkIncludes.py: No such file or directory
 make[1]: *** [check-includes] Error 1
 make[1]: *** Waiting for unfinished jobs....
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26447#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online