[tor-bugs] #26933 [Core Tor/Tor]: Minor memleak in HSv3 configuration

[Tor Bug Tracker & Wiki]

#26933: Minor memleak in HSv3 configuration
------------------------------+--------------------------------------
     Reporter:  asn           |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  easy memleak hsv3 tor-hs
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------------
 I ran my HSv3 under valgrind for a while. I didn't find anything major.

 The only interesting thing I could find is this leaked string during
 service configuration:
 {{{
 ==13380== 26 bytes in 1 blocks are still reachable in loss record 545 of
 654
 ==13380==    at 0x4C2BC20: malloc (vg_replace_malloc.c:296)
 ==13380==    by 0x2EB977: tor_malloc_ (util_malloc.c:45)
 ==13380==    by 0x2D6946: esc_for_log (util.c:605)
 ==13380==    by 0x2D6C3D: escaped (util.c:677)
 ==13380==    by 0x26D26C: config_generic_service (hs_config.c:372)
 ==13380==    by 0x26D26C: config_service (hs_config.c:471)
 ==13380==    by 0x26D26C: hs_config_service_all (hs_config.c:555)
 ==13380==    by 0x206996: options_validate (config.c:4384)
 ==13380==    by 0x20AB2F: options_init_from_string (config.c:5497)
 ==13380==    by 0x20B170: options_init_from_torrc (config.c:5273)
 ==13380==    by 0x15B7BC: tor_init (main.c:3524)
 ==13380==    by 0x15C23C: tor_run_main (main.c:4239)
 ==13380==    by 0x1557A9: tor_main (tor_api.c:84)
 ==13380==    by 0x155518: main (tor_main.c:32)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26933>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online