[tor-bugs] #20874 [Core Tor/Tor]: ReachableAddresses adds an extra reject *:* on every SAVECONF

[Tor Bug Tracker & Wiki]

#20874: ReachableAddresses adds an extra reject *:* on every SAVECONF
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, torrc, saveconf,         |  Actual Points:
  configuration, annoyance, 035-triaged-         |
  in-20180711                                    |
Parent ID:                                       |         Points:  0.5
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * cc: atagar (added)
 * status:  needs_review => needs_revision


Comment:

 This change does not appear to append the reject line if the user uses
 ReachableORAddresses?

 It looks like the code in parse_reachable_addresses() has the property
 that ReachableAddresses can set either/both OR and DIR addresses if those
 options are not set, but if they are set, they take precidence over
 ReachableAddresses. I'm guessing we want this append logic to follow the
 same behavior?

 Also maybe this means it should be part of parse_reachable_addresses() and
 not policies_parse_from_options() for that reason?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20874#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online