[tor-bugs] #26893 [Core Tor/Tor]: all-zeroes special case is for relay IDs, not cell digests

[Tor Bug Tracker & Wiki]

#26893: all-zeroes special case is for relay IDs, not cell digests
------------------------------+--------------------------------
     Reporter:  catalyst      |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-spec, fast-fix
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 tor-spec.txt Section 5.3 (Creating circuits) says:
 {{{
    As special cases, if the extend cell includes a digest of
    all zeroes, or asks to extend back to the relay that sent the extend
 }}}
 The implementation uses "digest" internally to refer to relay ID hashes,
 while tor-spec.txt primarily uses it to refer to the truncated running
 SHA-1 hash that relays use to "recognize" a cell as targeting them.

 arma says this probably intends to refer to relay ID hashes, and pointed
 to commit e34727a65c411a6260f3960ff8a753088e287565.

 We should reword this text to make it clear it refers to relay ID hashes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26893>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online