[tor-bugs] #26890 [Core Tor/Tor]: Redefine coverity version of the BUG macro

[Tor Bug Tracker & Wiki]

#26890: Redefine coverity version of the BUG macro
------------------------------+-------------------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  035-must fast-fix ci coverity
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-------------------------------------------
 Our BUG macro definition is all wrong for coverity.

 We shouldn't be including __coverity_panic__, since hitting a BUG doesn't
 actually mean Tor will crashed, and we shouldn't imply that the condition
 might be visited anyway.  We should just do "#define BUG(x) (x)" when
 we're building with coverity.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26890>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online