[tor-bugs] #26876 [Core Tor/Tor]: tor.real fails to start on macOS 10.9

[Tor Bug Tracker & Wiki]

#26876: tor.real fails to start on macOS 10.9
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  ff60-esr, tbb-needs, regression,     |  Actual Points:
  fast-fix, 033-backport, 034-backport,          |
  035-must                                       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  ff60-esr, tbb-needs, regression, fast-fix, 033-backport,
     034-backport =>
     ff60-esr, tbb-needs, regression, fast-fix, 033-backport, 034-backport,
     035-must
 * status:  assigned => needs_review


Comment:

 Oh, and the availability macro was only introduced in the 10.12 header, so
 there are two different bugs here:
 https://opensource.apple.com/source/xnu/xnu-3789.1.32/osfmk/mach/mach_time.h.auto.html

 Unfortunately, I can't do the same checks for iOS, because the kernel
 headers aren't open-source. (I only have access to the latest headers,
 which claim that the symbol was introduced in iOS 8.0.) I've asked in
 #tor-mobile if they also need this fix.

 See my branch bug26876_033.

 On my macOS 10.13 with the default settings, it detects a Yosemite or
 later target, and the mach_approximate_time symbol is imported by the
 binary.

 With `-DMAC_OS_X_VERSION_MIN_REQUIRED=1009`, it detects a pre-Yosemite
 target, and the mach_approximate_time symbol is not imported by the
 binary.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26876#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online