[tor-bugs] #26812 [Core Tor/Tor]: hs: Adding client authorization through control port on an existing service fails

[Tor Bug Tracker & Wiki]

#26812: hs: Adding client authorization through control port on an existing service
fails
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 (Comes from reported issue in #26776).

 The scenario is this:

 * You have a configured HiddenService that has been configured through the
 control port (`SETCONF`) *without* client authorization.

 * From the control port, you then `SETCONF` that same hidden service
 directory but with client authorization this time. The service will still
 be reachable without the client authorization that has just been set up.

 The issue I believe comes from our transition from staging to the ready
 service list. See the crazy function `rend_service_prune_list_impl_()` for
 v2, we keep the introduction points alive even if we now have client
 authorization. Not good...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26812>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online