[tor-bugs] #26754 [Core Tor/Tor]: stop using BUFFERS_PRIVATE

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jul 11 12:18:01 UTC 2018


#26754: stop using BUFFERS_PRIVATE
--------------------------+----------------------------------
 Reporter:  cypherpunks   |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  buffers       |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Hi, thanks for the patch!

 I like the idea of doing this very much, but we need some approach here
 that doesn't involve using so many tmp buffers.  This code is critical-
 path in Tor, and it would be better not to increase the number of copies
 or system calls.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26754#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list