[tor-bugs] #19506 [Core Tor/Tor]: Tool to inspect id signing certs

[Tor Bug Tracker & Wiki]

#19506: Tool to inspect id signing certs
-------------------------------------------------+-------------------------
 Reporter:  weasel                               |          Owner:  rl1987
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.4-rc
 Severity:  Normal                               |     Resolution:
 Keywords:  ed25519 tor-relay monitor tooling    |  Actual Points:
  admin-tools                                    |
Parent ID:                                       |         Points:  2
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_review => needs_revision


Comment:

 Few notes for revision:
 1. The got_tag variable here comes from a strdrup(). It needs to be freed.
 2. Instead of printing out the return value, consider using strerror() to
 get a human readable string for the errno?
 crypto_read_tagged_contents_from_file() preserves errno for this reason.
 3. Are we sure we want to make the user specify the path to the cert and
 not the cert file itself? This may be confusing? But I could be convinced
 that it is not, if it is hard to find the cert among whatever else is in
 that dir.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19506#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online