[tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

[Tor Bug Tracker & Wiki]

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
-----------------------------------------------+---------------------------
 Reporter:  sysrqb                             |          Owner:  tbb-team
     Type:  task                               |         Status:
                                               |  needs_review
 Priority:  Very High                          |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531                             |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by igt0):

 I will review in batches:


 ''97ca08c7c8bc Bug 25741 - TBA: Add mobile-override of 000-tor-browser
 prefs''

 1. Do we want to disable the app.update.enabled (I am asking because of
 the #26242)?

 2. About the user agent, I think it would be rv: 60.0, Gecko/60.0 and
 Firefox/60.0. Do we need to specify the android version?

 3. I think we should disable all the sensors. (device.sensors.*)

 ''69bdd94ecb8e Bug 25741 - TBA: Add default configure options in dedicated
 file''
 **LGTM**

 ''ae36b1d20547 Bug 25741 - TBA: Do not register Stumbler listener at start
 up''
 **LGTM**

 ''6d7a72d3e95b Bug 25741 - TBA: Add an AppConstant for
 TOR_BROWSER_VERSION''
 I think we need to add something in the .mozconfigure, no, specifying the
 current browser version?

 ''9d8303c14531 Bug 25741 - TBA: Disable features at compile-time''
 **LGTM**

 ''66ecd900c106 Bug 25741 - TBA: Add mozconfig for Android and pertinent
 branding files.''
 Are we going to use Orfox assets? if yes, **LGTM**

 ''2f7b87b25f2b Bug 25741 - TBA: Move GCM Push prefs within preprocessor
 guard''
 **LGTM**

 ''970c95dff0b3 Bug 25741 - TBA: Exclude unwanted Stumbler tests''
 **LGTM**

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online