[tor-bugs] #26522 [Core Tor/Tor]: strncat() without bounds

[Tor Bug Tracker & Wiki]

#26522: strncat() without bounds
----------------------------------------+----------------------------------
 Reporter:  Dhiraj                      |          Owner:  rl1987
     Type:  defect                      |         Status:  needs_review
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.5.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Major                       |     Resolution:
 Keywords:  security-low, 035-proposed  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


Comment:

 Replying to [comment:3 rl1987]:
 > https://github.com/torproject/tor/pull/204
 >
 > Not sure if it's a good thing to introduce dependency between lib/err
 and lib/string. Perhaps the reason `strncat()` was used was to avoid
 including stuff from lib/string?

 That's unlikely, because strncat() was used long before we refactored code
 into lib/string.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26522#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online