[tor-bugs] #26522 [Core Tor/Tor]: strncat() without bounds

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jul 3 10:55:53 UTC 2018


#26522: strncat() without bounds
----------------------------------------+----------------------------------
 Reporter:  Dhiraj                      |          Owner:  rl1987
     Type:  defect                      |         Status:  needs_review
 Priority:  Medium                      |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor                |        Version:
 Severity:  Major                       |     Resolution:
 Keywords:  security-low, 035-proposed  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------
Changes (by rl1987):

 * status:  accepted => needs_review


Comment:

 https://github.com/torproject/tor/pull/204

 Not sure if it's a good thing to introduce dependency between lib/err and
 lib/string. Perhaps the reason `strncat()` was used was to avoid including
 stuff from lib/string?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26522#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list