[tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jul 2 20:50:19 UTC 2018
#21349: Split up very long functions in entrynodes.c
------------------------------------------------+--------------------------
Reporter: nickm | Owner: rl1987
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Minor | Resolution:
Keywords: refactor technical-debt tor-client | Actual Points:
Parent ID: | Points:
Reviewer: asn | Sponsor:
------------------------------------------------+--------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
Thanks for the revisions! They look good to me, modulo the two minor
things I pointed out in the new PR.
IMO, you should also squash the three latest commits (122ad11, 5453dd8,
d3fcbcb) in the previous commits so that it's easier for nickm to review
and merge.
I'm switching this to needs_revision for the above but we are almost done
here!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21349#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list