[tor-bugs] #25094 [Core Tor/Tor]: 24902 fix breaks on clang

[Tor Bug Tracker & Wiki]

#25094: 24902 fix breaks on clang
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  (none)
     Type:  defect        |         Status:  closed
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:  fixed
 Keywords:  tor-dos       |  Actual Points:  0.2
Parent ID:  #24902        |         Points:  0.2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:6 dgoulet]:
 > I've taken teor patch and fixed very minor thing (mostly syntax) and
 made the `circuit_rate` to be a `uint64_t` instead of casting it. The
 getter returns the `uin32_t` value so we are good in conversion there.
 Just one less cast.

 This works, but there are no unit tests that make sure it does.
 (We could add them if we liked.)

 Also, there is no comment that explains why we return a uint32_t as a
 uint64_t.

 I don't think we need to fix either of these things.
 If anyone wants to, we can do it in master going forward.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25094#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online