[tor-bugs] #24975 [Core Tor/Tor]: sched: scheduler_notify_networkstatus_changed() calls select_scheduler() without the new consensus

[Tor Bug Tracker & Wiki]

#24975: sched: scheduler_notify_networkstatus_changed() calls select_scheduler()
without the new consensus
-------------------------------------+------------------------------------
 Reporter:  dgoulet                  |          Owner:  dgoulet
     Type:  defect                   |         Status:  reopened
 Priority:  High                     |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  032-backport, tor-sched  |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  armadev                  |        Sponsor:
-------------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  closed => reopened
 * reviewer:   => armadev
 * resolution:  fixed =>


Comment:

 Ok sorry, I fucked up and arma noticed so good!

 I've pushed a revert and then a commit that does the right thing.

 The problem was that the function was moved _after_ but was still using
 `get_latest_consensus()` for the parameter of the "old consensus". After
 we set globally the new consensus, that doesn't work so well...

 Solution is to go with a before and after function. To achieve such, the
 scheduler is a bit changed but only parameters that are actually never
 used are removed.

 Branch: `bug24975_032_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24975#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online