[tor-bugs] #25094 [Core Tor/Tor]: 24902 fix breaks on clang

[Tor Bug Tracker & Wiki]

#25094: 24902 fix breaks on clang
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  0.2
Parent ID:  #24902        |         Points:  0.2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * points:   => 0.2
 * actualpoints:   => 0.2


Comment:

 I added another commit that skips the entire function if the current time
 is equal to the last refill time.

 This makes the `time == 0` edge case nicer.

 The behaviour was:
 * new clients get a full refill on every cell as long as `time == 0`
 * existing clients get a full refill on every cell as long as `time == 0`

 Now it is:
 * new clients don't get refills as long as `time == 0`
 * new clients get one full refill as soon as `time >= 1`
 * existing clients get one normal refill if they have any cells when `time
 == 0`
 * existing clients get one full refill as soon as `time >= 1`, if they had
 a refill when `time == 0`

 And I think that's about as much time as it's worth spending on this edge
 case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25094#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online