[tor-bugs] #24000 [Core Tor/Tor]: circuit_send_intermediate_onion_skin() and extend_cell_format() should check for IPv6

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jan 30 20:17:34 UTC 2018


#24000: circuit_send_intermediate_onion_skin() and extend_cell_format() should
check for IPv6
-----------------------------------+------------------------------------
 Reporter:  teor                   |          Owner:  nickm
     Type:  defect                 |         Status:  merge_ready
 Priority:  Medium                 |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor           |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  ipv6, review-group-31  |  Actual Points:
Parent ID:  #24403                 |         Points:  0.5
 Reviewer:  dgoulet                |        Sponsor:
-----------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 We only check `orport_ipv4` in `check_extend_cell()` so this is only a
 gate keeping for the `extend_cell_format()` that does this:

 {{{
   tor_addr_copy(&ec.orport_ipv4.addr, &hop->extend_info->addr);
   ec.orport_ipv4.port = hop->extend_info->port;
 }}}

 All in all, if the `extend_info->addr` is not an IPv4, we have trouble in
 the woods which could happen with a coding error and sending non IPv4 in
 those cells in a release would be bad.

 I think that check is OK to have and ultimately we will have a proper
 "extend_info_t -> extend cell" layer.

 lgtm;

 I just wonder if teor is OK with this considering is comment:3 ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24000#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list