[tor-bugs] #25089 [Applications/Tor Browser]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
--------------------------------------+--------------------------
 Reporter:  ro0ter                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Major                     |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------
Changes (by ro0ter):

 * owner:  (none) => tbb-team
 * component:  - Select a component => Applications/Tor Browser


Comment:

 some log excerpt caused by wrong proxy password:

 1/30/2018 15:26:35 PM.700 [NOTICE] DisableNetwork is set. Tor will not
 make or accept non-control network connections. Shutting down all existing
 connections.
 1/30/2018 15:26:35 PM.700 [NOTICE] DisableNetwork is set. Tor will not
 make or accept non-control network connections. Shutting down all existing
 connections.
 1/30/2018 15:26:35 PM.700 [NOTICE] DisableNetwork is set. Tor will not
 make or accept non-control network connections. Shutting down all existing
 connections.
 1/30/2018 15:26:35 PM.700 [NOTICE] Opening Socks listener on
 xx.xx.xx.xx:xxx
 1/30/2018 15:26:36 PM.600 [NOTICE] Bootstrapped 5%: Connecting to
 directory server
 1/30/2018 15:26:36 PM.600 [NOTICE] Bootstrapped 10%: Finishing handshake
 with directory server
 1/30/2018 15:26:36 PM.800 [WARN] The https proxy sent back an unexpected
 status code 407 ("Proxy Authentication Required"). Closing.
 1/30/2018 15:26:36 PM.800 [WARN] Proxy Client: unable to connect to
 xx.xx.xx.xx:xxx
 1/30/2018 15:26:37 PM.600 [WARN] The https proxy sent back an unexpected
 status code 407 ("Proxy Authentication Required"). Closing.
 1/30/2018 15:26:37 PM.600 [WARN] Proxy Client: unable to connect to
 xx.xx.xx.xx:xxx
 1/30/2018 15:26:37 PM.700 [WARN] The https proxy sent back an unexpected
 status code 407 ("Proxy Authentication Required"). Closing.

 [ ... ]

 1/30/2018 15:27:36 PM.900 [WARN] Proxy Client: unable to connect to
 xx.xx.xx.xx:xxx
 1/30/2018 15:27:46 PM.900 [WARN] The https proxy sent back an unexpected
 status code 407 ("Proxy Authentication Required"). Closing.
 1/30/2018 15:27:46 PM.900 [WARN] Proxy Client: unable to connect to
 xx.xx.xx.xx:xxx

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25089#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online