[tor-bugs] #24484 [Core Tor/Tor]: free(NULL) always works (nowadays) so stop acting like it might not

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jan 25 22:45:32 UTC 2018


#24484: free(NULL) always works (nowadays) so stop acting like it might not
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Code changes look good!  The autoconf test is a great idea, too.  Please
 also delete the part of the `tor_free()` comment that implies that
 `free(NULL)` won't work.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24484#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list