[tor-bugs] #24914 [Core Tor/Tor]: Maybe make relay_digest_matches() not use tor_malloc()

[Tor Bug Tracker & Wiki]

#24914: Maybe make relay_digest_matches() not use tor_malloc()
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-relay     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Yeah: I don't see an attack from not zeroing it, but I think it's
 generally good to zero crypto stuff reflexively.

 I've added a couple of fixup commits; better now?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24914#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online