[tor-bugs] #24914 [Core Tor/Tor]: Maybe make relay_digest_matches() not use tor_malloc()

[Tor Bug Tracker & Wiki]

#24914: Maybe make relay_digest_matches() not use tor_malloc()
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-relay     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


Comment:

 Why not use `crypto_digest_assign()` and `crypto_digest_t` in the new
 checkpoint data structure (inline)?

 Asking because `crypto_digest_checkpoint()` and `crypto_digest_restore()`
 really looks like the assign function.

 Also extra whitespaces:

 {{{
 +crypto_digest_checkpoint(crypto_digest_checkpoint_t *checkpoint,
 +                              const crypto_digest_t *digest)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24914#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online