[tor-bugs] #24946 [Core Tor/Tor]: connection_ap_expire_beginning(): Bug: circuit->purpose == CIRCUIT_PURPOSE_C_GENERAL failed

[Tor Bug Tracker & Wiki]

#24946: connection_ap_expire_beginning(): Bug: circuit->purpose ==
CIRCUIT_PURPOSE_C_GENERAL failed
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  mikeperry
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by mikeperry):

 Replying to [comment:5 asn]:
 > Mike's fix LGTM too.
 >
 > Mike any chance we should also be checking for `HS_VANGUARD`
 `circ->purpose` in `connection_ap_expire_beginning()` too?

 No, this check is only for circuits that can have attempted streams
 attached. HS_VANGAURD should never have any streams.

 > WRT mike's question on comment:2: I don't think we have inherent rate-
 limiting for hsdir queries on hsv2 or hsv3, but I don't expect Tor clients
 to make many such circuits. Perhaps we should merge the bug fix patch we
 already have, and maybe open a separate ticket about investigating the
 potential issue of `count_pending_general_client_circuits()`?

 Ok. #24989.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24946#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online