[tor-bugs] #24975 [Core Tor/Tor]: sched: scheduler_notify_networkstatus_changed() calls select_scheduler() without the new consensus

[Tor Bug Tracker & Wiki]

#24975: sched: scheduler_notify_networkstatus_changed() calls select_scheduler()
without the new consensus
------------------------------+-------------------------------------
     Reporter:  dgoulet       |      Owner:  dgoulet
         Type:  defect        |     Status:  assigned
     Priority:  High          |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  032-backport, tor-sched
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-------------------------------------
 `select_scheduler()` is called when a new consensus arrives with
 `scheduler_notify_networkstatus_changed()` but never takes the new
 consensus for which at that point it is not yet set as the global
 consensus.

 It needs to use `new_c`.

 This is not good because of that, we can't change anything with the
 consensus at runtime.........

 Thanks to Roger for finding this out here:
 https://oniongit.eu/dgoulet/tor/merge_requests/17#note_2153

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24975>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online