[tor-bugs] #23573 [Core Tor/Tor]: Do we want to close all connections when tor closes?

[Tor Bug Tracker & Wiki]

#23573: Do we want to close all connections when tor closes?
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  shutdown, privcount, correctness,    |  Actual Points:
  chutney-wants, review-group-24                 |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:7 teor]:
 > Replying to [comment:5 nickm]:
 > > Needs a changes file.
 >
 > Ack.
 >
 > > I'd rather have a real fix for #23570 than the sleep() call here, if
 at all possible.
 > > Maybe we should just fflush() everything?
 >
 > The sleep() call isn't a great fix. I think fflush() would be a good
 idea: I'm not sure if it's enough.

 The correct call here is queued_events_flush_all(1).
 The sleep(1) does nothing (or doesn't do much), because we've just shut
 down all our timers. Also, the sleep() call crashes the sandbox, if it is
 enabled.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23573#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online