[tor-bugs] #24952 [Core Tor/Tor]: channel: channel_tls_get_remote_addr_method() should return the "real_addr" of the connection

[Tor Bug Tracker & Wiki]

#24952: channel: channel_tls_get_remote_addr_method() should return the "real_addr"
of the connection
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-channel   |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by ffmancera):

 * status:  new => needs_review


Comment:

 > If we do this and merge it, let's remember to look at every user of this
 method to make sure > that nothing depended on the old behavior.

 `channel_tls_get_remote_addr_method()` is used only by
 `chan->get_remote_addr` which is used by `channel_get_addr_if_possible()`
 in `channel.c`. So if I am not wrong nothing depends on the old behaviour.

 Here is the patch, check my github
 [https://github.com/ffmancera/tor/tree/bug24952 branch bug24952]. I hope
 everything is fine :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24952#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online