[tor-bugs] #24946 [Core Tor/Tor]: connection_ap_expire_beginning(): Bug: circuit->purpose == CIRCUIT_PURPOSE_C_GENERAL failed

[Tor Bug Tracker & Wiki]

#24946: connection_ap_expire_beginning(): Bug: circuit->purpose ==
CIRCUIT_PURPOSE_C_GENERAL failed
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  mikeperry
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by mikeperry):

 * status:  assigned => needs_review


Comment:

 Ok, I fixed this, along with and 3 others that I found by looking at every
 occurrence of CIRCUIT_PURPOSE_C_GENERAL (which
 CIRCUIT_PURPOSE_C_HSDIR_POST and CIRCUIT_PURPOSE_C_HSDIR_GEt were split
 off from). https://oniongit.eu/mikeperry/tor/commits/bug24946

 There is one other instance in count_pending_general_client_circuits(),
 which is called by circuit_get_open_circ_or_launch() to determine if we
 have too many non-hidden service client circuits available. If HSDIR
 retries are already rate limited (I think they are, but I am not 100%
 sure), then I don't think we need to patch that one. It would be nice if
 someone who knows could confirm that hsdir attempts/retries are rate
 limited for v2 and v3 though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24946#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online