[tor-bugs] #24895 [Core Tor/Tor]: MAX_REND_FAILURES is 1, but we will try three times

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 19 15:30:11 UTC 2018


#24895: MAX_REND_FAILURES is 1, but we will try three times
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  032-backport, 031-backport,          |  Actual Points:
  030-backport, 029-backport, 025-backport       |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 This looks good! Ok, so I made two tiny winy changes here and I'll explain
 why. They are in the fixup commit `9e3b63b041f0e60e`:

 1. I changed the name `maxrendfailures` to `hs_service_max_rdv_failures`
 which, like you said above, is to specifically point it out to be service
 side. Secondly, because this needs to be merged forward, with v3 in 032,
 that value is used by both versions and moved to `hs_common.h` so the
 naming is important to clearly name space it to the "hs" subsystem and
 identify it as service. Third, `rend` in the code is associated with v2
 thus the use of `rdv` instead. Finally, I think a name like that will be
 more explicit when read from the consensus or torrc file by the dirauth.

 2. I simply made the default, min and max values a `#define` which, when
 merging forward, will be moved to `hs_common.c`.

 This patch won't merge forward cleanly because of the big v3 change
 starting in 031 so here are the respective branches per version.

 NOTE: The fixup commit from above is in all the branches so --autosquash
 might be desirable before merging. And I hope I made the merge forward
 OK... Let me know if anything goes wrong. There will be a very easy
 conflict from 029 to 030.

 Branch: `ticket24895_029_01`, `ticket24895_031_01` and
 `ticket24895_032_01`
 Spec branch: `ticket24895_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24895#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list