[tor-bugs] #24588 [Core Tor/Tor]: Make signal handlers optional, for starting Tor in-process

[Tor Bug Tracker & Wiki]

#24588: Make signal handlers optional, for starting Tor in-process
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-mobile, s8-api, review-group-30  |  Actual Points:
Parent ID:  #23684                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by nickm):

 > Why is this listed for controllers in control-spec.txt if you can't
 SETCONF/change the value while Tor is running (as per the check added to
 options_transition_allowed)?

 That's because it's meant for use by controllers only, not in a regular
 torrc.  If you're not embedding Tor, this option isn't useful.  We already
 have similar controller-only unchangeable options in control-spec.txt,
 like OwningControllerFD.

 > I was also briefly confused what the event handler was doing in the else
 where signal handlers are set to disabled. Maybe document that it is for
 the SIGNAL control port command/activate_signals()?

 Okay! I've added a commit to improve the documentation in general.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24588#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online