[tor-bugs] #24895 [Core Tor/Tor]: MAX_REND_FAILURES is 1, but we will try three times

[Tor Bug Tracker & Wiki]

#24895: MAX_REND_FAILURES is 1, but we will try three times
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  032-backport, 031-backport,          |  Actual Points:
  030-backport, 029-backport, 025-backport       |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arma):

 * status:  needs_revision => needs_review


Comment:

 My {{{bug24895-029}}} branch adds this consensus param, and applies to
 maint-0.2.9. (I don't think any relevant huge services still run on 0.2.5,
 so I am fine leaving oldoldstable alone here.)

 I picked a max of 10 (out of my hat, "chosen by fair dice roll"), and a
 default of 2 (based on discussion above). I could maybe have picked a
 default of 1, since we're going to deploy 1 on the network as soon as this
 patch goes out, and we have no plans to change it from 1. But I went with
 2 in case we later decide to try it.

 I also went with the consensus param name "maxrendfailures", which is
 maybe a bit vague because it doesn't specify whether I mean the client
 side or the service side. If somebody likes a different size bike shed,
 now is the time to speak up. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24895#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online