[tor-bugs] #24588 [Core Tor/Tor]: Make signal handlers optional, for starting Tor in-process
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Jan 18 21:59:16 UTC 2018
#24588: Make signal handlers optional, for starting Tor in-process
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-mobile, s8-api, review-group-30 | Actual Points:
Parent ID: #23684 | Points:
Reviewer: | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Changes (by mikeperry):
* status: needs_review => needs_revision
Comment:
Why is this listed for controllers in control-spec.txt if you can't
SETCONF/change the value while Tor is running (as per the check added to
options_transition_allowed)?
If there is another way for controllers to use this other than SETCONF,
probably the control-spec.txt should say to do that (and not SETCONF). If
not, then this should go into the manpage (and probably should go into the
manpae anyway).
I was also briefly confused what the event handler was doing in the else
where signal handlers are set to disabled. Maybe document that it is for
the SIGNAL control port command/activate_signals()?
I think the rest of this looks OK though. Tests pass w/ hardening,
spaces/changes OK, etc.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24588#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list