[tor-bugs] #22488 [Metrics/Onionoo]: Include relay version listed in consensus in addition to platform line from server descriptor

[Tor Bug Tracker & Wiki]

#22488: Include relay version listed in consensus in addition to platform line from
server descriptor
-----------------------------+-------------------------------
 Reporter:  cypherpunks      |          Owner:  metrics-team
     Type:  enhancement      |         Status:  closed
 Priority:  High             |      Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:  fixed
 Keywords:  metrics-2018     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-------------------------------
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:23 teor]:
 > Replying to [comment:22 cypherpunks]:
 > > Replying to [comment:21 teor]:
 > > > * clarify that the recommended version uses the consensus version at
 https://metrics.torproject.org/onionoo.html#details_relay_recommended_version
 >
 > Please see my branch bug22488 at https://github.com/teor2345/metrics-
 web.git
 >
 > It updates the Onionoo documentation for recommended_version. The
 versions used in recommended_version come from the consensus or bridge
 networkstatus. I checked the code for relays and bridges.

 Thanks for providing that patch! Merged with trivial tweaks, and deployed.

 > > > * make Onionoo parse the platform field in the descriptor and
 compare it to the consensus version
 > > Yes, it would be great if onionoo includes both and atlas could then
 display a clear info when they are not the same (and display only one if
 they are the same, so to not confuse operators).
 >
 > I am not sure if this fix is a good idea. We don't trust descriptors
 when they are not in a consensus. (Their details can be wrong.) So why are
 any of our tools using them? And what should Onionoo do if a relay has
 multiple descriptors?
 >
 > And I don't have time to write this fix. It looks like new feature that
 involves at least one new field. Or a rethink of how we parse descriptors
 and which ones we should parse.

 In theory, this should be as simple as checking whether the `"platform"`
 string starts with `"Tor " + version_field_content + " "`. This could
 already be done in Relay Search and doesn't require a new Onionoo field.
 At least it could be a start, if we really care.

 > For an alternative fix where Onionoo stops parsing untrusted
 descriptors, see #24932.

 Indeed, this is worth thinking about. I'll comment on the ticket why this
 might be tricky to implement, though. But it seems like something we
 should do.

 Okay, I think with the documentation patch merged and #24864 and #24932
 still open, it's safe to close this ticket now. Doing so. Thanks,
 everyone!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22488#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online