[tor-bugs] #21074 [Core Tor/Tor]: setrlimit fails OSX Sierra

[Tor Bug Tracker & Wiki]

#21074: setrlimit fails OSX Sierra
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.7
 Severity:  Normal                               |     Resolution:
 Keywords:  OSX, Sierra, setrlimit, tbb-needs,   |  Actual Points:
  031-backport, review-group-29 032-backport     |
  029-backport                                   |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 This patch seems to have caused a signed/unsigned comparison warning on
 FreeBSD:
 {{{
 21:15:20 ../tor/src/common/compat.c:1750:23: error: comparison of integers
 of different signs: 'uint64_t' (aka 'unsigned long') and 'rlim_t' (aka
 'long') [-Werror,-Wsign-compare]
 21:15:20       rlim.rlim_cur = MIN(try_limit, rlim.rlim_cur);
 21:15:20                       ^   ~~~~~~~~~  ~~~~~~~~~~~~~
 21:15:20 /usr/include/sys/param.h:299:23: note: expanded from macro 'MIN'
 21:15:20 #define MIN(a,b) (((a)<(b))?(a):(b))
 21:15:20                       ^
 }}}

 I've added a new commit to the `bug21074_029` branch to fix this, and
 merged the branch to master again.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21074#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online